fix(web): prevent resetting date input when entering 0 #7415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9dc825f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c8c40034.immich.pages.dev |
| Branch Preview URL: | https://fix-web-date-input-zero.immich.pages.dev |
danieldietzler
approved these changes
Feb 26, 2024
Comment on lines
+4
to
+8
| interface $$Props extends HTMLInputAttributes { | ||
| type: 'date' | 'datetime-local'; | ||
| } | ||
|
|
||
| export let value: $$Props['value'] = undefined; |
There was a problem hiding this comment.
This is cool! Didn't know you could do this in svelte 4 already - I was excited for this in svelte 5 though haha
|
Hi Michel, can you help resolve the conflict? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date input field will reset completely when a 0 is entered anywhere. The date is considered invalid in that case and the value will be set to an empty string, causing the input to be reset. Fixed by filtering for an empty string and only setting that when focus on the input is lost.
Fixes #6621 and fixes #5673