feat(server): easy RKMPP video encoding #7460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
bb214a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://229481bf.immich.pages.dev |
| Branch Preview URL: | https://refactor-easy-rkmpp-video-tr.immich.pages.dev |
| @@ -38,12 +38,6 @@ services: | |||
| - /dev/dri:/dev/dri | |||
| - /dev/dma_heap:/dev/dma_heap | |||
| - /dev/mpp_service:/dev/mpp_service | |||
| volumes: | |||
There was a problem hiding this comment.
Is this considered a breaking change? What happens if the user doesn't change this?
There was a problem hiding this comment.
it's not a breaking change.
if the user keeps an old version of this file that includes the mounts, these files are still mounted into the container but unused. no issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses the RKMPP encoder built into the recent jellyfin-ffmpeg release.
This simplifies both the code and especially usage (no need to mount binaries into the container)!
Downsides: Slower transcoding due to software decoding and scaling. Previously, hardware decoding and scaling was used. We might be able to re-enable hardware decoding in the future (follow-up PR).