Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): rkmpp hardware decoding scaling #7472

Merged
merged 2 commits into from Feb 28, 2024

Conversation

fyfrey
Copy link
Contributor

@fyfrey fyfrey commented Feb 27, 2024

enables full hardware transcoding via RKMPP on RK3588 platform: decode, scale filter, encode

transcode speed: 20x realtime for hevc, 27x realtime for h264 🚀

Copy link

cloudflare-pages bot commented Feb 27, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8a315e4
Status: ✅  Deploy successful!
Preview URL: https://241eaaeb.immich.pages.dev
Branch Preview URL: https://feat-rkmpp-hardware-decoding.immich.pages.dev

View logs

Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test that it works with an HDR video?

server/src/domain/media/media.util.ts Outdated Show resolved Hide resolved
@fyfrey
Copy link
Contributor Author

fyfrey commented Feb 27, 2024

Any freely available test video?
What should I look out for? I don't have any HDR monitor etc^^

@mertalev
Copy link
Contributor

It just needs to have the tone-mapping stuff in the command and transcode without any error logs. Any random YT video with HDR will work.

@michelheusschen
Copy link
Contributor

For test videos I use these samples from Kodi, there are also links to external sources with even more videos

@fyfrey
Copy link
Contributor Author

fyfrey commented Feb 27, 2024

I've disable hardware decoding/scaling for HDR videos (encoding still works).

I'll try to get hardware decoding and hardware tonemapping via OpenCL to work in another PR. the RK3588 SOC has hardware support for HDR tonemapping... I just don't know yet whether this ffmpeg build can use it and if so, how.

@mertalev
Copy link
Contributor

Sounds good. Jellyfin uses libplacebo and we use their FFmpeg build, so it should be possible. I just haven't been able to get the right command to make it work.

@mertalev mertalev merged commit 87a7825 into main Feb 28, 2024
25 checks passed
@mertalev mertalev deleted the feat/rkmpp-hardware-decoding-scaling branch February 28, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants