Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build tweaks #7484

Merged
merged 1 commit into from Feb 29, 2024
Merged

chore: build tweaks #7484

merged 1 commit into from Feb 29, 2024

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Feb 28, 2024

  • don't write to github action cache (with the base image there does not seem to be much benefit to caching as the build is faster without it)
  • don't send test assets to the docker build context
  • Use system tmp directory
  • Only download chrome browser

Copy link

cloudflare-pages bot commented Feb 28, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7525d7d
Status: ✅  Deploy successful!
Preview URL: https://40b7b1ff.immich.pages.dev
Branch Preview URL: https://dev-docker-build.immich.pages.dev

View logs

@jrasm91 jrasm91 requested a review from bo0tzz February 28, 2024 01:53
@jrasm91 jrasm91 marked this pull request as ready for review February 28, 2024 01:53
@bo0tzz
Copy link
Member

bo0tzz commented Feb 28, 2024

with the base image there does not seem to be much benefit to caching as the build is faster without it

How have you checked this? Scrolling through the log of successful docker builds (https://github.com/immich-app/immich/actions/workflows/docker.yml?query=is%3Asuccess), I see most jobs taking 6-8 minutes with some outliers at 14-15, and the jobs for this PR taking 11 minutes. That seems to me like the cache is usually giving a worthwhile speedup.

@jrasm91
Copy link
Contributor Author

jrasm91 commented Feb 29, 2024

I can't be bothered to look at this right now. I am under the impression that first runs take a long time because of the additional overhead to write out the cache, but also the slowest part of the whole process is definitely building for ARM. I will just omit these changes for now and merge the rest.

@jrasm91 jrasm91 merged commit bb3d81b into main Feb 29, 2024
25 checks passed
@jrasm91 jrasm91 deleted the dev/docker-build branch February 29, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants