Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add explicit registry to docker image names #7496

Merged
merged 1 commit into from Feb 28, 2024

Conversation

saimonn
Copy link
Contributor

@saimonn saimonn commented Feb 28, 2024

closes #7495

Some container engines (hello podman 馃憢 ) don't use registry.hub.docker.com by default and won't be able to load redis or pgvecto-rs images from the composition.

This pull request explicitly add the image name prefix needed to fix that.

@jrasm91 jrasm91 requested a review from bo0tzz February 28, 2024 12:18
@alextran1502 alextran1502 added the deployment Deployment related tasks label Feb 28, 2024
@alextran1502 alextran1502 merged commit 784d92d into immich-app:main Feb 28, 2024
24 of 25 checks passed
@jbtrystram
Copy link

Nice ! Thanks for giving podman some love :)

@wutr
Copy link

wutr commented Mar 3, 2024

I've been using docker.io (instead of registry.hub.docker.com/library/) since migrating to podman a year ago. I think docker.com does some DNS magic to get to the correct server.

docker.io seems a bit more readable. Is there anything against using it instead?

edit: Unless it is podman that does the magic to get to registry.hub.docker.com/library when it receives docker.io.

edit2: docker.io has A records that directly point to the same AWS IPs as hub.docker.com (the latter via a few CNAME records). I can't find any documentation that favours one over the other or even clarifies things. Maybe I'm looking in the wrong places. Docker's own documentation doesn't seem to mention it. And of course Docker only searches its own registry so they have no need to explain.

docker.io/library is for "official" images, updated here by pull requests: https://github.com/docker-library/official-images

docker.io/repo (repo being the name registered by the repository's owner) is for images published directly by the repository's maintainer.

(docker.io and hub.docker.com can be used interchangeably)

@tleydxdy
Copy link

tleydxdy commented Mar 5, 2024

it appears that registry.hub.docker.com is blocked by GFW in china while docker.io is not (very strange yes). with this merge I was unable to pull new images on my chinese server. Of course the blocking action can change anytime and I wouldn't expect immich devs to have to deal with it. but in the mean time can we change the host to use docker.io? I've changed it locally, and hopefully others running into the same issue can find this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Deployment related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provided docker-compose,yml doesn't work with podman-compose
6 participants