Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web): ascending order for slideshow #7502

Merged
merged 8 commits into from Mar 2, 2024
Merged

feat(web): ascending order for slideshow #7502

merged 8 commits into from Mar 2, 2024

Conversation

martabal
Copy link
Member

What's changed

This PR adds an ascending / descending mode for the slideshow

Screenshots

2024-02-28.18-47-37-2.mp4

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Feb 28, 2024 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3187b47
Status:⚡️  Build in progress...

View logs

@martabal martabal force-pushed the feat/ascending-order-slideshow branch from 4aebbd9 to 9dce3f6 Compare February 28, 2024 18:14
@michelheusschen
Copy link
Contributor

Looks good and works as expected. I'm only not so sure about how the order options are presented to the user. Maybe three buttons or a radio input with Backward | Shuffle | Forward would be more intuitive.

@martabal
Copy link
Member Author

Looks good and works as expected. I'm only not so sure about how the order options are presented to the user. Maybe three buttons or a radio input with Backward | Shuffle | Forward would be more intuitive.

I agree. What do you think about using a dropdown menu (like the one in the album list to select the order) ?

@michelheusschen
Copy link
Contributor

A dropdown menu would be an improvement, but since there are only three options a radio input has my preference. But I'm fine with both.

@martabal martabal force-pushed the feat/ascending-order-slideshow branch from 9764203 to 373a16f Compare February 28, 2024 20:25
@martabal
Copy link
Member Author

martabal commented Feb 28, 2024 •
edited

Yeah, I like dropdown more, it's easier to adapt if we add new navigation mechanisms in the future

@michelheusschen
Copy link
Contributor

The dropdown text disappears on small screens

image

@michelheusschen
Copy link
Contributor

Is hiding the dropdown text on small screens intentional? I'd say just show the text, there's enough space.

@martabal
Copy link
Member Author

martabal commented Mar 1, 2024

Is hiding the dropdown text on small screens intentional? I'd say just show the text, there's enough space.

Nope, it should be fixed

danieldietzler
danieldietzler approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 merged commit 8d44afe into main Mar 2, 2024
23 of 24 checks passed
@alextran1502 alextran1502 deleted the feat/ascending-order-slideshow branch March 2, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@jrasm91 jrasm91 Awaiting requested review from jrasm91

@michelheusschen michelheusschen Awaiting requested review from michelheusschen

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martabal @michelheusschen @danieldietzler @alextran1502