Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter people when using smart search #7521

Merged
merged 3 commits into from Feb 29, 2024

Conversation

michelheusschen
Copy link
Contributor

Implements filtering on people when using smart search. Ideally I would've added this to searchAssetBuilder, but then TypeORM creates an invalid query for metadata search.

Copy link

cloudflare-pages bot commented Feb 29, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 785b440
Status: ✅  Deploy successful!
Preview URL: https://b79efa9e.immich.pages.dev
Branch Preview URL: https://feat-smart-search-people-fil.immich.pages.dev

View logs

Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think grouping the faces first will work.

server/src/infra/repositories/search.repository.ts Outdated Show resolved Hide resolved
@mertalev mertalev merged commit c89d91e into main Feb 29, 2024
25 checks passed
@mertalev mertalev deleted the feat/smart-search-people-filter branch February 29, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants