chore(server): Move library watcher to microservices #7533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
8b9b5bb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://12442231.immich.pages.dev |
| Branch Preview URL: | https://chore-library-init-micro.immich.pages.dev |
jrasm91
reviewed
Feb 29, 2024
There was a problem hiding this comment.
This looks good so far, but you need to prevent library scanning from running on installs which run multiple instances of microservices. I think you can accomplish this by asking for a postgres lock, although you might need to get more info from @zackpollard or @mertalev on that.
jrasm91
reviewed
Feb 29, 2024
jrasm91
reviewed
Feb 29, 2024
jrasm91
reviewed
Feb 29, 2024
|
My test shows the current lock implementation did not work as expected, will have to do some debugging later: only one microservice should have initiated the watch |
|
The return type is an array: |
Yeah, I have to get used to ts not doing runtime type checking. Thanks :) |
…e/library-init-micro
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mertalev
reviewed
Feb 29, 2024
mertalev
reviewed
Mar 1, 2024
mertalev
approved these changes
Mar 1, 2024
This reverts commit 84ab5ab.
…e/library-init-micro
…e/library-init-micro
…e/library-init-micro
aviv926
pushed a commit
to aviv926/immich
that referenced
this pull request
Mar 7, 2024
* move watcher init to micro * document watcher recovery * chore: fix lint * add try lock * use global library watch lock * fix: ensure lock stays on * fix: mocks * unit test for library watch lock * move statement to correct test * fix: correct return type of try lock * fix: tests * add library teardown * add chokidar error handler * make event strings an enum * wait for event refactor * refactor event type mocks * expect correct error * don't release lock in teardown * chore: lint * use enum * fix mock * fix lint * fix watcher await * remove await * simplify typing * remove async * Revert "remove async" This reverts commit 84ab5ab. * can now change watch settings at runtime * fix lint * only watch libraries if enabled --------- Co-authored-by: mertalev <101130780+mertalev@users.noreply.github.com> Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the library watcher to be running in the microservices.
Inspiration is from @jrasm91 who suggested this as a better option to #7509.
Here, if the watcher fails and stalls (as in #6833) we can stop the microservices container and disable the library watcher, unbricking the Immich install in a clean way
Added lock so that only one microservice takes care of the watcher in the case of multiple micros
Tests performed: