Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused upload property #7535

Merged
merged 2 commits into from Feb 29, 2024
Merged

Conversation

jrasm91
Copy link
Contributor

@jrasm91 jrasm91 commented Feb 29, 2024

No description provided.

Copy link

cloudflare-pages bot commented Feb 29, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 89f1dd9
Status: ✅  Deploy successful!
Preview URL: https://7aa50cd3.immich.pages.dev
Branch Preview URL: https://chore-remove-unused-property.immich.pages.dev

View logs

@jrasm91 jrasm91 marked this pull request as ready for review February 29, 2024 16:27
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +6 to +9
export class CreateAssetDto {
@ValidateUUID({ optional: true })
libraryId?: string;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sort them alphabetically? pls ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want the boolean properties next to each other since that is why I think the decorators got missed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. Got it

@jrasm91 jrasm91 merged commit 15a4a4a into main Feb 29, 2024
25 checks passed
@jrasm91 jrasm91 deleted the chore/remove-unused-property branch February 29, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants