Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): bottom bar Upload translation #7553

Merged

Conversation

waclaw66
Copy link
Contributor

@waclaw66 waclaw66 commented Mar 1, 2024

This PR adds missing Upload button translation.

@JW-CH
Copy link
Contributor

JW-CH commented Mar 1, 2024

Why was the "Build Mobile" skipped?

@jrasm91
Copy link
Contributor

jrasm91 commented Mar 1, 2024

Why was the "Build Mobile" skipped?

It requires a signing key. The mobile is still built in the Test > Mobile action though. Are you looking for an APK or something?

@JW-CH
Copy link
Contributor

JW-CH commented Mar 1, 2024

Why was the "Build Mobile" skipped?

It requires a signing key. The mobile is still built in the Test > Mobile action though. Are you looking for an APK or something?

No, I just thought it builds when there were changes in the mobile source. All good.

@alextran1502 alextran1502 merged commit 670a383 into immich-app:main Mar 1, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants