perf(web): asset delete #7555
Merged
perf(web): asset delete #7555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
a22a0c9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://785cbdff.immich.pages.dev |
| Branch Preview URL: | https://perf-web-asset-delete.immich.pages.dev |
jrasm91
reviewed
Mar 1, 2024
|
Can't we just pass |
No, the value of |
jrasm91
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server batches asset deletes, however on the web every delete action is done individually causing performance issues when deleting a large amount of assets. The main change is removing
AssetStore.removeAssetin favor of a batched variant. Previously deleting a bucket with 10_000 assets took about 4 seconds for just updating the asset store, now it's down to 3-5 milliseconds.