Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): prevent leaking isFavorite and isArchived info #7580

Merged
merged 5 commits into from Mar 2, 2024

Conversation

martabal
Copy link
Member

@martabal martabal commented Mar 2, 2024

Prevent leaking the isFavorite data for non-owners until full support for favorites.
fixes #7577

Screenshots

Before After
Screenshot from 2024-03-02 17-24-34 Screenshot from 2024-03-02 17-23-43

Copy link

cloudflare-pages bot commented Mar 2, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 98ead66
Status: ✅  Deploy successful!
Preview URL: https://0f7ea951.immich.pages.dev
Branch Preview URL: https://fix-prevent-leaking-favorite.immich.pages.dev

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an e2e for this.

@martabal martabal force-pushed the fix/prevent-leaking-favorites-shared-albums branch from 088e971 to e19a9a5 Compare March 2, 2024 19:29
@martabal martabal changed the title fix(server): prevent leaking favorites info fix(server): prevent leaking isFavorite and isArchived info Mar 2, 2024
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally prefer to have auth as the first argument but that doesn't really matter

@martabal
Copy link
Member Author

martabal commented Mar 2, 2024

I generally prefer to have auth as the first argument but that doesn't really matter

Optional parameters must be last in the parameter list.

@jrasm91 jrasm91 merged commit ebe7a14 into main Mar 2, 2024
26 checks passed
@jrasm91 jrasm91 deleted the fix/prevent-leaking-favorites-shared-albums branch March 2, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can see what photos owner of shared album likes
3 participants