feat(server): allow oauth claim to set 0 for no quota #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
approved these changes
Mar 2, 2024
jrasm91
approved these changes
Mar 2, 2024
| @@ -543,7 +543,7 @@ describe('AuthService', () => { | |||
| loginResponseStub.user1oauth, | |||
| ); | |||
|
|
|||
| expect(userMock.create).toHaveBeenCalledWith(userDto.userWithDefaultStorageQuota); | |||
| expect(userMock.create).toHaveBeenCalledWith(userDto.userWithUnsetQuotaClaim); | |||
There was a problem hiding this comment.
It might be better to remove these user objects and just assert it matches an object containing the right quota value.
There was a problem hiding this comment.
Yeah I can make that change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrasm91 thanks for all the help on #7548 - Do we want to support the use case of having a default quota set but setting it to unlimited for specific users via the claim? I was sticking with
0to match the UI and default quota language.