fix(server, web): prevent reload when liking an asset #7589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
afb51d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2bda9149.immich.pages.dev |
| Branch Preview URL: | https://fix-favorite-and-archive.immich.pages.dev |
martabal
changed the title
|
I think we should always send them since they will be sent eventually when a user can do those actions. |
Currently, only owners can archive and favorite assets, but the day when we'll implement a mechanism so all users can like and/or archive assets, we'll have to update the backend and the frontend logic, so it's more maintenance. And I don't really like the fact we're sending incorrect information. |
jrasm91
reviewed
Mar 3, 2024
|
Sending false is not incorrect. The asset is not favorited by the user. It may change to true in the future in which case I don't think it makes sense to have deleted it from the response payload. |
martabal
force-pushed
the
fix/favorite-and-archive
branch
from
6eccd1f
to
96b5535
Compare
martabal
force-pushed
the
fix/favorite-and-archive
branch
from
96b5535
to
c8ed35f
Compare
martabal
force-pushed
the
fix/favorite-and-archive
branch
from
c8ed35f
to
afb51d4
Compare
michelheusschen
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents photo viewer from reloading when you like an asset