Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server, web): add checkbox to create user screen for shouldChang… #7598

Conversation

samholton
Copy link
Contributor

…ePassword

Addresses #7592

Also saw an old discussion in discord around this.

Defaults to true to keep behavior consistent with current flow.

before
before

after
after

@samholton
Copy link
Contributor Author

Could someone rerun the failed check? It appears it was a connection issue with npmjs

@alextran1502
Copy link
Contributor

alextran1502 commented Mar 3, 2024

It should always be required for the sake of the privacy of other users that use your instance.

On second thoughts, the admin can access the file system anyway so that renders my point above invalid

@alextran1502
Copy link
Contributor

Have you tested create new user with this flag disable and the user doesn't have to reenter the password on first login?

@samholton
Copy link
Contributor Author

samholton commented Mar 3, 2024

Yeah, I agree it should be enabled as well. But an admin could always create a user then login to the instance once and then share the account. I set it enabled by default.

Yes I tested with it both enabled and disabled. I checked the users table as well as logging in. The login bypassed the password change with it disabled.

@alextran1502 alextran1502 merged commit 7ef202c into immich-app:main Mar 4, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants