feat(web): use lib/utils/copyToClipboard for share link

[samholton]

Using Firefox, I noticed there was no button to copy the link on the create share modal. Upon looking to add it, I noticed there was some logic around if it should be shown or not. I removed module.canCopyImagesToClipboard and used the function in lib which was working in Firefox for me on the system settings page.

before

after

[alextran1502]

Hello, why do we remove onMount here?

[samholton]

Because check:svelte complained about it? :) I'm just getting into svelte, so perhaps it needs to remain? No longer needing to make this call within

const module = await import('copy-image-clipboard');

And leaving onMount it complained about no async call

[jrasm91]

The button won't work when accessed over insecure contexts.

https://developer.mozilla.org/en-US/docs/Web/API/Clipboard

[samholton]

The button won't work when accessed over insecure contexts.

https://developer.mozilla.org/en-US/docs/Web/API/Clipboard

I saw that, maybe I need to read some more because its working in my Firefox (both on Debian and Android). The copy lib is used elsewhere, so this would make it more consistent rather than loading the additional module which was hidden from the same Debian Firefox. It seems like there is some logic already built in https://github.com/immich-app/immich/blob/main/web/src/lib/utils.ts#L204

[samholton]

Ok, so localhost is considered secure. I setup /etc/hosts record and do get the error message now when clicking the copy button. So I think this is still an improvement to make it more consistent with other areas of the app. Perhaps we could add some logic to the lib function to set visibility and use that.

[samholton]

One last note, the old method hides it on my Firefox even over https while the new method shows and the copy functionality works.

[jrasm91]

Yes the old method is for copying an image to the clipboard, which I think uses canvas and other unrelated things.

[jrasm91]

LGTM.

[danieldietzler]

LGTM