feat(web): search by filename #7624

alextran1502 · 2024-03-04T15:38:52Z

Added radio button to search for file's name

cloudflare-pages · 2024-03-04T15:38:54Z

Deploying with Cloudflare Pages

Latest commit:	`a84dac1`
Status:	✅ Deploy successful!
Preview URL:	https://ed712adb.immich.pages.dev
Branch Preview URL:	https://web-filename-search.immich.pages.dev

View logs

michelheusschen

You should also add an entry to this object

immich/web/src/routes/(user)/search/+page.svelte

Lines 161 to 162 in de71d8e

    
             function getHumanReadableSearchKey(key: keyof SearchTerms): string { 
        
               const keyMap: Partial<Record<keyof SearchTerms, string>> = {

web/src/lib/components/shared-components/search-bar/search-filter-box.svelte

web/src/lib/components/shared-components/search-bar/search-text-section.svelte

waclaw66 · 2024-03-04T16:29:51Z

Wouldn't be better to not add another control and search filenames automatically? Is it because some performance reason?

server/src/infra/infra.utils.ts

alextran1502 · 2024-03-04T16:31:56Z

@waclaw66 SmartSearch and MetadataSearch are two different categories with separate API endpoints. File name search falls into the MetadataSearch category

mertalev · 2024-03-04T16:40:14Z

I feel like this should just be a toggle for smart / context vs full-text search. We don't want a radio button for each text field we support searching for

waclaw66 · 2024-03-04T16:43:03Z

@waclaw66 SmartSearch and MetadataSearch are two different categories with separate API endpoints. File name search falls into the MetadataSearch category

I see, however that control is something not interesting from user perspective, to much controls bring confusion. Please just take this as a kind reminder.

alextran1502 · 2024-03-04T17:09:29Z

@mertalev @waclaw66 both of you bring good points, let me think again how to best handle this situation

mertalev · 2024-03-04T17:13:15Z

This is probably where the hybrid search stuff would be ideal. Then we could hit the smart search endpoint and not expose a separate control for this.

mertalev · 2024-03-04T17:14:59Z

But it might have an effect on performance.

web/src/lib/components/shared-components/search-bar/search-text-section.svelte

aviv926 · 2024-03-04T23:54:50Z

Wouldn't be better to not add another control and search filenames automatically? Is it because some performance reason?

Does sending 2 API requests one for CLIP and one for MetadataSearch sound like something possible (or does it add a lot of load to the system)?

Or since a thumb file with a known extension is created for each file, maybe it can be used so that in every search it will search if there is a webp type file that matches [search] if so it will retrieve it in the search results.

mertalev · 2024-03-05T03:37:41Z

server/src/infra/infra.utils.ts

  builder.andWhere(_.omitBy(path, _.isUndefined));

+  if (options.originalFileName) {


You should rename this since we search on the file path

server/src/infra/migrations/1709608140355-AddAssetOriginalPathTrigramIndex.ts

web/src/lib/components/shared-components/search-bar/search-text-section.svelte

…t-section.svelte Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

…-search

server/src/infra/infra.utils.ts

web/src/lib/components/shared-components/search-bar/search-filter-box.svelte

web/src/lib/components/shared-components/search-bar/search-text-section.svelte

jrasm91 · 2024-03-05T18:58:56Z

server/src/infra/infra.utils.ts

  builder.andWhere(_.omitBy(path, _.isUndefined));

+  if (options.originalPath) {


does this not support doing an exact match on original path anymore?

…-search

jrasm91

Seems fine. Not a huge fan of this code change for search requiring an update to a method used for so many other features.

aviv926 · 2024-03-06T16:31:33Z

Does it actually replace m: or a feature in addition to it?

alextran1502 · 2024-03-06T16:36:06Z

Does it actually replace m: or a feature in addition to it?

It is a replacement, there is no more m: syntax

mertalev · 2024-03-06T16:36:51Z

As a feature it replaces m:, but it's specifically for file names right now.

Toggle to search by filename

94ead4a

alextran1502 added the 🖥️web label Mar 4, 2024

michelheusschen reviewed Mar 4, 2024

View reviewed changes

web/src/lib/components/shared-components/search-bar/search-filter-box.svelte Outdated Show resolved Hide resolved

web/src/lib/components/shared-components/search-bar/search-text-section.svelte Outdated Show resolved Hide resolved

wild card search and pr feedback

369c29a

alextran1502 commented Mar 4, 2024

View reviewed changes

server/src/infra/infra.utils.ts Show resolved Hide resolved

Pr feedback

a21aaed

alextran1502 changed the title ~~Toggle to search by filename~~ feat(web): search by filename Mar 4, 2024

alextran1502 force-pushed the web/filename-search branch from cf37250 to a21aaed Compare March 4, 2024 22:35

naming

9e3c9c1

mertalev reviewed Mar 4, 2024

View reviewed changes

web/src/lib/components/shared-components/search-bar/search-text-section.svelte Outdated Show resolved Hide resolved

alextran1502 added 2 commits March 4, 2024 20:51

placeholder

f232f37

Create index

9530a32

alextran1502 requested review from mertalev and jrasm91 March 5, 2024 03:18

alextran1502 added 2 commits March 4, 2024 21:25

pr feedback

5dde7a3

pr feedback

436ea37

mertalev reviewed Mar 5, 2024

View reviewed changes

jrasm91 reviewed Mar 5, 2024

View reviewed changes

web/src/lib/components/shared-components/search-bar/search-text-section.svelte Outdated Show resolved Hide resolved

alextran1502 and others added 3 commits March 5, 2024 09:43

Update web/src/lib/components/shared-components/search-bar/search-tex…

56a97a0

…t-section.svelte Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

Merge branch 'main' of github.com:immich-app/immich into web/filename…

eddcc18

…-search

pr feedback

41f4b67

mertalev reviewed Mar 5, 2024

View reviewed changes

server/src/infra/infra.utils.ts Outdated Show resolved Hide resolved

pr feedback

75c19e4

jrasm91 reviewed Mar 5, 2024

View reviewed changes

alextran1502 added 3 commits March 5, 2024 13:23

pr feedback

7e418d7

pr feedback

63ae135

Merge branch 'main' of github.com:immich-app/immich into web/filename…

a84dac1

…-search

jrasm91 approved these changes Mar 5, 2024

View reviewed changes

alextran1502 merged commit 2f53f6a into main Mar 5, 2024
25 checks passed

alextran1502 deleted the web/filename-search branch March 5, 2024 23:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(web): search by filename #7624

feat(web): search by filename #7624

alextran1502 commented Mar 4, 2024 •

edited

cloudflare-pages bot commented Mar 4, 2024 •

edited

michelheusschen left a comment

waclaw66 commented Mar 4, 2024 •

edited

alextran1502 commented Mar 4, 2024

mertalev commented Mar 4, 2024 •

edited

waclaw66 commented Mar 4, 2024

alextran1502 commented Mar 4, 2024

mertalev commented Mar 4, 2024

mertalev commented Mar 4, 2024

aviv926 commented Mar 4, 2024

mertalev Mar 5, 2024

jrasm91 Mar 5, 2024

alextran1502 Mar 5, 2024

jrasm91 left a comment

aviv926 commented Mar 6, 2024

alextran1502 commented Mar 6, 2024

mertalev commented Mar 6, 2024

	function getHumanReadableSearchKey(key: keyof SearchTerms): string {
	const keyMap: Partial<Record<keyof SearchTerms, string>> = {

		builder.andWhere(_.omitBy(path, _.isUndefined));

		if (options.originalFileName) {

		builder.andWhere(_.omitBy(path, _.isUndefined));

		if (options.originalPath) {

feat(web): search by filename #7624

feat(web): search by filename #7624

Conversation

alextran1502 commented Mar 4, 2024 • edited

cloudflare-pages bot commented Mar 4, 2024 • edited

Deploying with Cloudflare Pages

michelheusschen left a comment

Choose a reason for hiding this comment

waclaw66 commented Mar 4, 2024 • edited

alextran1502 commented Mar 4, 2024

mertalev commented Mar 4, 2024 • edited

waclaw66 commented Mar 4, 2024

alextran1502 commented Mar 4, 2024

mertalev commented Mar 4, 2024

mertalev commented Mar 4, 2024

aviv926 commented Mar 4, 2024

mertalev Mar 5, 2024

Choose a reason for hiding this comment

jrasm91 Mar 5, 2024

Choose a reason for hiding this comment

alextran1502 Mar 5, 2024

Choose a reason for hiding this comment

jrasm91 left a comment

Choose a reason for hiding this comment

aviv926 commented Mar 6, 2024

alextran1502 commented Mar 6, 2024

mertalev commented Mar 6, 2024

alextran1502 commented Mar 4, 2024 •

edited

cloudflare-pages bot commented Mar 4, 2024 •

edited

waclaw66 commented Mar 4, 2024 •

edited

mertalev commented Mar 4, 2024 •

edited