Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): hardware HDR tonemapping for RKMPP #7655

Merged
merged 2 commits into from
Mar 9, 2024
Merged

feat(server): hardware HDR tonemapping for RKMPP #7655

merged 2 commits into from
Mar 9, 2024

Conversation

fyfrey
Copy link
Contributor

@fyfrey fyfrey commented Mar 5, 2024

enables full hardware transcoding for HDR videos on Rockchip SoCs

  • pipeline: hardware decode -> scaling -> opencl tonemapping -> hardware encoding
  • only RK3588 supports tonemapping, other Rockchips SoCs still use software decoding/scaling/tonemapping but retain hardware encoding
  • users need to provide libmali.so for tonemapping
  • added docs for RKMPP transcoding
  • enables 4K HDR -> FHD SDR transcode at 8x realtime speed 🚀 (in software it's 0.25x realtime...)

@fyfrey fyfrey requested a review from mertalev March 5, 2024 17:27
@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Mar 5, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8de658f
Status: ✅  Deploy successful!
Preview URL: https://f1de45a7.immich.pages.dev
Branch Preview URL: https://dev-rkmpp-hdr-tonemapping.immich.pages.dev

View logs

@fyfrey fyfrey force-pushed the dev/rkmpp-hdr-tonemapping branch from ae5e4d7 to 8de658f Compare March 6, 2024 11:22
@fyfrey fyfrey requested a review from mertalev March 6, 2024 11:37
mertalev
mertalev approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@mertalev mertalev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! This will also make it easier to add hardware tone-mapping for the other backends.

@mertalev mertalev merged commit 3f1d37e into main Mar 9, 2024
26 checks passed
@mertalev mertalev deleted the dev/rkmpp-hdr-tonemapping branch March 9, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertalev mertalev mertalev approved these changes

Assignees
No one assigned
Labels
feel-free-to-merge-👍 🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fyfrey @mertalev