feat(server): deterministic download order #7658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrasm91
commented
Mar 5, 2024
jrasm91
commented
- add files to the archive in a way that reflects the original request order
- fixes the download e2e test that sometimes fails when the order is reversed
Deploying with
|
| Latest commit: |
007c0a7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://68479aa8.immich.pages.dev |
| Branch Preview URL: | https://feat-deterministic-download.immich.pages.dev |
jrasm91
force-pushed
the
feat/deterministic-download-order
branch
from
24d5ebe
to
007c0a7
Compare
alextran1502
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.