Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(web): albums list (1) #7660

Merged
merged 11 commits into from Mar 14, 2024
Merged

refactor(web): albums list (1) #7660

merged 11 commits into from Mar 14, 2024
+447 −471

Conversation

martabal
Copy link
Member

@martabal martabal commented Mar 5, 2024 •
edited

This is the first PR of the album list refactoring.

This first PR splits the code into albums-list and albums-controls components.
The second will focus on adding these components to the sharing tab

How Has This Been Tested?

  • Create an album
  • Delete an album (with the cover and list views)
  • Change the order (desc/asc) with the dropdown and the table headers
  • Change an album's name
  • Change the view mode (List/Cover)
  • Search for an album
  • Automatically remove empty albums
  • Go to an album

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Mar 5, 2024 •
edited

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f13481
Status: ✅  Deploy successful!
Preview URL: https://84124486.immich.pages.dev
Branch Preview URL: https://refactor-albums-list.immich.pages.dev

View logs

@martabal martabal changed the title refactor(web): albums list refactor(web): albums list (1) Mar 5, 2024
@alextran1502
Copy link
Contributor

Can you help define a list of tests that have been done with the related changes?

@martabal martabal force-pushed the refactor/albums-list branch 4 times, most recently from 17fd995 to 0fe548e Compare March 5, 2024 22:29
@martabal martabal marked this pull request as draft March 6, 2024 09:04
@martabal martabal marked this pull request as ready for review March 6, 2024 17:43
michelheusschen
michelheusschen reviewed Mar 6, 2024
View reviewed changes
web/src/lib/stores/albums.store.ts Outdated Show resolved Hide resolved
web/src/lib/utils/albums.ts Outdated Show resolved Hide resolved
web/src/lib/components/album-page/albums-list.svelte Show resolved Hide resolved
web/src/lib/components/album-page/albums-list.svelte Outdated Show resolved Hide resolved
@martabal martabal force-pushed the refactor/albums-list branch 2 times, most recently from 270a904 to 865081e Compare March 6, 2024 22:01
michelheusschen
michelheusschen approved these changes Mar 14, 2024
View reviewed changes
web/src/lib/utils/date-time.ts Outdated Show resolved Hide resolved
@alextran1502 alextran1502 merged commit c04dfdf into main Mar 14, 2024
24 checks passed
@alextran1502 alextran1502 deleted the refactor/albums-list branch March 14, 2024 19:05
@martabal martabal mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler left review comments

@michelheusschen michelheusschen michelheusschen approved these changes

@jrasm91 jrasm91 Awaiting requested review from jrasm91

@alextran1502 alextran1502 Awaiting requested review from alextran1502

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martabal @alextran1502 @danieldietzler @michelheusschen