Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server,web): make user deletion delay configurable #7663

Conversation

samholton
Copy link
Contributor

@samholton samholton commented Mar 5, 2024

First part to add a new User Settings section to add configuration option for user deletion delay. Next up is to add a force option to queue up user for immediate deletion.

delete delay

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jrasm91
Copy link
Contributor

jrasm91 commented Mar 5, 2024

I mean it might need to be min={1}

@samholton
Copy link
Contributor Author

I mean it might need to be min={1}

min=1 worked but updated it to be consistent with the others

@alextran1502
Copy link
Contributor

Hello, thank you for the PR! What is the impact of changing the number of day for already queued for delete user?

@samholton
Copy link
Contributor Author

samholton commented Mar 6, 2024

Hello, thank you for the PR! What is the impact of changing the number of day for already queued for delete user?

The number of days is not stored with the user record, so each time the batch job runs, it will evaluate the queued users against the current setting value.

I attempted to indicate this in the text: https://github.com/immich-app/immich/pull/7663/files#diff-2a84dfc76e5b23ae7a77e3ba11ca749128214aff7a18e5e207acfe551df563fbR29

Maybe I should update that to something like

Changing this will re-evaluate users already queued for deletion.

@jrasm91
Copy link
Contributor

jrasm91 commented Mar 6, 2024

We should maybe clarify somewhere that a job runs at midnight to check for users that are ready to be deleted and then we can add that this change will take effect the next time the job runs.

@samholton
Copy link
Contributor Author

samholton commented Mar 6, 2024

How's this look? (haven't pushed it yet)

updated text

@jrasm91
Copy link
Contributor

jrasm91 commented Mar 6, 2024

Yeah that looks good to me.

@alextran1502 alextran1502 merged commit 9125999 into immich-app:main Mar 6, 2024
24 checks passed
@samholton samholton deleted the feature/make-user-deletion-delay-configurable branch March 6, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants