New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server,web): make user deletion delay configurable #7663
feat(server,web): make user deletion delay configurable #7663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
web/src/lib/components/admin-page/settings/user-settings/user-settings.svelte
Outdated
Show resolved
Hide resolved
I mean it might need to be min={1} |
|
Hello, thank you for the PR! What is the impact of changing the number of day for already queued for delete user? |
The number of days is not stored with the user record, so each time the batch job runs, it will evaluate the queued users against the current setting value. I attempted to indicate this in the text: https://github.com/immich-app/immich/pull/7663/files#diff-2a84dfc76e5b23ae7a77e3ba11ca749128214aff7a18e5e207acfe551df563fbR29 Maybe I should update that to something like
|
We should maybe clarify somewhere that a job runs at midnight to check for users that are ready to be deleted and then we can add that this change will take effect the next time the job runs. |
Yeah that looks good to me. |
First part to add a new User Settings section to add configuration option for user deletion delay. Next up is to add a force option to queue up user for immediate deletion.