fix(web): consistent modal escape behavior #7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
7a2d680
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7e8af40b.immich.pages.dev |
| Branch Preview URL: | https://fix-web-consistent-modal-esc.immich.pages.dev |
aviv926
pushed a commit
to aviv926/immich
that referenced
this pull request
Mar 7, 2024
* fix(web): consistent modal escape behavior * make onClose optional
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The escape key inconsistently closes modals, sometimes doing nothing and other times closing the modal and navigating to the previous page.
To address this the FullscreenModal exposes a callback that combines the
clickOutsideandonEscapeevents. The clickOutside action has been modified (in a backwards compatible way) to accept callback functions. Using a callback function foronEscapeprevents the escape key from propagating and navigating to previous pages.Not all changes are related to this issue, some refactoring is included. I've manually tested all instances where
FullScreenModalwas used and some ofConfirmDialogue