chore(server): save original file name with extension #7679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
07d3136
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ed7d2197.immich.pages.dev |
| Branch Preview URL: | https://server-save-original-filenam.immich.pages.dev |
jrasm91
reviewed
Mar 6, 2024
alextran1502
commented
Mar 6, 2024
| @@ -0,0 +1,20 @@ | |||
| import { MigrationInterface, QueryRunner } from 'typeorm'; | |||
|
|
|||
| export class AddExtensionToOriginalFileName1709763765506 implements MigrationInterface { | |||
There was a problem hiding this comment.
It looks fine. Only potential concern is that it doesn't handle filenames with no extension, but I think we reject any files without extensions anyway.
mertalev
reviewed
Mar 6, 2024
mertalev
reviewed
Mar 7, 2024
mertalev
approved these changes
Mar 7, 2024
Co-authored-by: Mert <101130780+mertalev@users.noreply.github.com>
|
Can you fix this? immich/web/src/lib/utils/asset-utils.ts Line 162 in 3da2b05 |
aviv926
pushed a commit
to aviv926/immich
that referenced
this pull request
Mar 7, 2024
* chore(server): save original file name with extension * extract extension * update e2e test * update e2e test * download archive * fix download archive appending name * pr feedback * remove unused code * test * unit test * remove unused code * migration * noops * pr feedback * Update server/src/domain/download/download.service.ts Co-authored-by: Mert <101130780+mertalev@users.noreply.github.com> --------- Co-authored-by: Mert <101130780+mertalev@users.noreply.github.com>
This was referenced Mar 8, 2024
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.