refactor: e2e #7703
Merged
refactor: e2e #7703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bo0tzz
approved these changes
Mar 7, 2024
Deploying with
|
| Latest commit: |
b1ad020
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fce26137.immich.pages.dev |
| Branch Preview URL: | https://refactor-e2e.immich.pages.dev |
jrasm91
commented
Mar 7, 2024
e2e/src/setup.ts
Outdated
| _reject = reject; | ||
| }); | ||
|
|
||
| const timeout = setTimeout(() => _reject(), 15_000); |
There was a problem hiding this comment.
If the compose project doesn't come up or runs into an error this would hang indefinitely. Now it throws a timeout exception after 15 seconds.
|
|
||
| export const apiUtils = { | ||
| setup: () => { | ||
| setApiEndpoint: () => { |
There was a problem hiding this comment.
Looks like this only needs to be called (for each test) for the web specs.
aviv926
pushed a commit
to aviv926/immich
that referenced
this pull request
Mar 7, 2024
* refactor: e2e * fix: submodule check * chore: extend startup timeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.