feat(server): create a person with optional values #7706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f3edf69
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cf940112.immich.pages.dev |
| Branch Preview URL: | https://refactor-person-api.immich.pages.dev |
danieldietzler
approved these changes
Mar 7, 2024
| }); | ||
|
|
||
| it('should not accept invalid birth dates', async () => { | ||
| for (const { birthDate, response } of invalidBirthday) { |
There was a problem hiding this comment.
Maybe we should move the for each out of the it for a more helpful output if the test fails?
There was a problem hiding this comment.
I will do it in a follow up. There is only one test that runs either way right now.
Comment on lines
+226
to
228
| if (assetId) { | ||
| await this.jobRepository.queue({ name: JobName.GENERATE_PERSON_THUMBNAIL, data: { id } }); | ||
| } |
There was a problem hiding this comment.
Can't we merge this if with the if starting in l. 214?
There was a problem hiding this comment.
No, the faceId needs to be saved before the job can be queued. I don't want there to be a race condition if the job runs before the update happens.
aviv926
pushed a commit
to aviv926/immich
that referenced
this pull request
Mar 7, 2024
* feat: create person dto * chore: open api * fix: e2e * fix: web usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
birthDate,isHidden, andnamewhen creating a person