Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): admin access to edit library #7708

Merged
1 commit merged into from Mar 7, 2024
Merged

Conversation

alextran1502
Copy link
Contributor

No description provided.

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 307ffc9
Status:⚡️  Build in progress...

View logs

@alextran1502 alextran1502 closed this pull request by merging all changes into main in ba5d525 Mar 7, 2024
@alextran1502 alextran1502 deleted the fix/admin-access-library branch March 7, 2024 18:05
Copy link
Contributor

@etnoy etnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my phone so haven't tested but it looks correct to me

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is fine. We probably can just delete all of these checks and related code, since this is restricted to admins at the route/api level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants