perf: precompress and cache assets #7757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
92f1906
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0ed07e91.immich.pages.dev |
| Branch Preview URL: | https://precompress.immich.pages.dev |
|
Lighthouse likes the change - the score went from 61-62 to 65. But it's also saying the caching is inefficient for static assets:
|
|
On main it only shows |
|
It had to check for a path prefix of |
mertalev
approved these changes
Mar 9, 2024
|
Thanks for catching and fixing that! |
alextran1502
added a commit
that referenced
this pull request
Mar 9, 2024
This reverts commit ba55e86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using
adapter-nodeas I originally planned, I thought it would require fewer changes to keep usingadapter-staticand swap out Nest's static serving for the static serving thatadapter-nodedoes. Usingadapter-nodemight not be a bad idea still, but this just seemed easierI tested this locally with
make prodand you can see assets being served withbrcontent encoding now