Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): Fixes local thumbnail image provider key #7766

Merged
merged 4 commits into from Mar 12, 2024

Conversation

martyfuhry
Copy link
Contributor

No description provided.

@martyfuhry martyfuhry self-assigned this Mar 9, 2024
Copy link

cloudflare-pages bot commented Mar 9, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b41aeef
Status: ✅  Deploy successful!
Preview URL: https://28ad6d4e.immich.pages.dev
Branch Preview URL: https://fix-thumnbnail-image-cache.immich.pages.dev

View logs

@alextran1502
Copy link
Contributor

What is the issue here, Marty?

@martyfuhry
Copy link
Contributor Author

The other image providers use their own class as their key for the image cache. This one uses Asset. For consistency and maintaining, especially now that we're adding more caches, we should use the same schema of keys for the image cache across all the image providers.

@alextran1502 alextran1502 enabled auto-merge (squash) March 12, 2024 03:00
@alextran1502 alextran1502 merged commit a1130b3 into main Mar 12, 2024
24 checks passed
@alextran1502 alextran1502 deleted the fix/thumnbnail-image-cache branch March 12, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants