refactor: asset e2e #7769
Merged
refactor: asset e2e #7769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrasm91
commented
Mar 9, 2024
jrasm91
commented
- refactor asset e2e tests
- remove unused files
Deploying with
|
| Latest commit: |
fa43bfd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://edac45fa.immich.pages.dev |
| Branch Preview URL: | https://refactor-asset-e2e.immich.pages.dev |
jrasm91
commented
Mar 9, 2024
Comment on lines
-1106
to
-1108
| describe(AssetRepository.name, () => { | ||
| describe('getWithout', () => { | ||
| describe('WithoutProperty.FACES', () => { |
There was a problem hiding this comment.
FYI, I have removed this set of tests. There is no way to test them in e2e and I'm not sure I care about adding them back anywhere else.
jrasm91
force-pushed
the
refactor/asset-e2e
branch
from
783e5df
to
fa43bfd
Compare
danieldietzler
approved these changes
Mar 9, 2024
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.