Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mobile): backup settings ui #7771

Merged
merged 2 commits into from
Mar 12, 2024
Merged

refactor(mobile): backup settings ui #7771

merged 2 commits into from
Mar 12, 2024

Conversation

shenlong-tanwen
Copy link
Member

Changes made:

  • Backup related options are updated to use the shared settings components to provide a consistent look across app settings
  • Backup settings are also added to the settings as a new section (It is still available through Backup page as well)
Backup in Settings Backup settings landscape
backup_in_settings backup_settings

@alextran1502 alextran1502 merged commit 3d36b1f into refactor/mobile-settings Mar 12, 2024
17 of 18 checks passed
@alextran1502 alextran1502 deleted the refactor/mobile-backup-settings branch March 12, 2024 03:08
alextran1502 added a commit that referenced this pull request Mar 12, 2024
@shenlong-tanwen @alextran1502
refactor(mobile): app settings (#7749)
7489db9 
* refactor(mobile): app settings

* Font size

* refactor(mobile): backup settings ui (#7771)

* refactor: SettingsButtonListTile

* refactor: Backup settings to App settings

---------

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>

* fix: invalidate appsettingsprovider on timeline setting change

* styling

---------

Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
Co-authored-by: Alex Tran <alex.tran1502@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

Assignees
No one assigned
Labels
📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shenlong-tanwen @alextran1502