Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): type checks for e2e #7800

Merged
merged 1 commit into from Mar 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
Expand Up @@ -196,6 +196,10 @@ jobs:
run: npm run format
if: ${{ !cancelled() }}

- name: Run tsc
run: npm run check
if: ${{ !cancelled() }}

- name: Install Playwright Browsers
run: npx playwright install --with-deps chromium
if: ${{ !cancelled() }}
Expand Down
3 changes: 2 additions & 1 deletion e2e/package.json
Expand Up @@ -12,7 +12,8 @@
"format": "prettier --check .",
"format:fix": "prettier --write .",
"lint": "eslint \"src/**/*.ts\" --max-warnings 0",
"lint:fix": "npm run lint -- --fix"
"lint:fix": "npm run lint -- --fix",
"check": "tsc --noEmit"
},
"keywords": [],
"author": "",
Expand Down
2 changes: 1 addition & 1 deletion e2e/src/api/specs/album.e2e-spec.ts
Expand Up @@ -92,7 +92,7 @@ describe('/album', () => {
}),
]);

await deleteUser({ id: user3.userId }, { headers: asBearerAuth(admin.accessToken) });
await deleteUser({ id: user3.userId, deleteUserDto: {} }, { headers: asBearerAuth(admin.accessToken) });
});

describe('GET /album', () => {
Expand Down
2 changes: 1 addition & 1 deletion e2e/src/api/specs/shared-link.e2e-spec.ts
Expand Up @@ -86,7 +86,7 @@ describe('/shared-link', () => {
}),
]);

await deleteUser({ id: user2.userId }, { headers: asBearerAuth(admin.accessToken) });
await deleteUser({ id: user2.userId, deleteUserDto: {} }, { headers: asBearerAuth(admin.accessToken) });
});

describe('GET /shared-link', () => {
Expand Down