Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): clarify use of concurrency option #7840

Merged
merged 3 commits into from Mar 12, 2024

Conversation

mertalev
Copy link
Contributor

Description

The concurrency option takes a number, but this isn't reflected in the help message.

@mertalev mertalev added the cli Tasks related to the Immich CLI label Mar 11, 2024
Copy link

cloudflare-pages bot commented Mar 11, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0cd9428
Status: ✅  Deploy successful!
Preview URL: https://16dc9b23.immich.pages.dev
Branch Preview URL: https://chore-cli-concurrency-flag.immich.pages.dev

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add any e2e tests for this? At least that it correctly accepts numbers and disallows other options?

@mertalev
Copy link
Contributor Author

Sure, I can add a test for that

@mertalev mertalev merged commit d09980f into main Mar 12, 2024
26 checks passed
@mertalev mertalev deleted the chore/cli-concurrency-flag branch March 12, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Tasks related to the Immich CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants