Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): small fixes for empty placeholder #7859

Merged
merged 1 commit into from Mar 12, 2024
Merged

Conversation

michelheusschen
Copy link
Contributor

fix(web): small fixes for empty placeholder

  • Use button when placeholder is clickable, otherwise use div
  • Remove alt text, because image is only decorative and text is already provided
  • Some general cleanup and rename actionHandler to onClick

There are no visual changes

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 85b7ebd
Status: ✅  Deploy successful!
Preview URL: https://56e7e85d.immich.pages.dev
Branch Preview URL: https://fix-web-empty-placeholder.immich.pages.dev

View logs

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jrasm91 jrasm91 merged commit b7e5407 into main Mar 12, 2024
24 of 25 checks passed
@jrasm91 jrasm91 deleted the fix/web-empty-placeholder branch March 12, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants