feat(mobile): add labels to app bar buttons #7865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-basten
commented
Mar 11, 2024
| @@ -80,6 +81,7 @@ class ImmichAppBar extends ConsumerWidget implements PreferredSizeWidget { | |||
| strokeWidth: 2, | |||
| strokeCap: StrokeCap.round, | |||
| valueColor: AlwaysStoppedAnimation<Color>(iconColor), | |||
| semanticsLabel: 'backup_controller_page_backup'.tr(), | |||
There was a problem hiding this comment.
In the future, it would be cool if these labels included the status of the backup. That's a cue that sighted users get from the icon, but screen readers miss. Something like:
- Backup (complete)
- Backup (in progress)
- Backup (off)
alextran1502
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds labels to some of the buttons in the top app bar for screen reader users, to provide context about where the buttons go.
Note: I did not modify the rightmost profile circle button, because I think new internationalization text will need to be added for this. Something like "Profile and settings" maybe, and modify the header of the resulting popup to match for predictability?
How Has This Been Tested?
Screenshots (if appropriate):
No visible changes
Checklist: