Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): sidebar menu links #7891

Merged
merged 1 commit into from Mar 12, 2024
Merged

Conversation

michelheusschen
Copy link
Contributor

  • Rename SideBarButton to SideBarLink
  • Move isSelected logic and anchor element to SideBarLink component
  • Wrap all menu links in nav element
  • Remove unused event listeners

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d81e51e
Status: ✅  Deploy successful!
Preview URL: https://06433077.immich.pages.dev
Branch Preview URL: https://refactor-web-sidebar-menu-li.immich.pages.dev

View logs

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrasm91 jrasm91 merged commit c24b6cf into main Mar 12, 2024
25 checks passed
@jrasm91 jrasm91 deleted the refactor/web-sidebar-menu-links branch March 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants