Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): correctly use button and link elements #7907

Merged
merged 1 commit into from Mar 12, 2024
Merged

fix(web): correctly use button and link elements #7907

merged 1 commit into from Mar 12, 2024

Conversation

michelheusschen
Copy link
Contributor

  • Use native button element instead of emulating them
  • Add blur event to people thumbnail to remove bounding box when focus is lost
  • Remove button element from icons that have no action
  • Converted div to link in SharedLinkCard

@cloudflare-pages Cloudflare Pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3207af1
Status: ✅  Deploy successful!
Preview URL: https://f8af083d.immich.pages.dev
Branch Preview URL: https://fix-web-correct-button-link.immich.pages.dev

View logs

jrasm91
jrasm91 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these types of changes. Ty

@jrasm91 jrasm91 merged commit b07ed3f into main Mar 12, 2024
25 checks passed
@jrasm91 jrasm91 deleted the fix/web-correct-button-link-usage branch March 12, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasm91 jrasm91 jrasm91 approved these changes

Assignees
No one assigned
Labels
🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michelheusschen @jrasm91