fix(web): Remove excess spacing on #asset-grid and search bar #7910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also move the search bar over :D? |
Sure. It's moved now. |
natedawg
changed the title
jrasm91
approved these changes
Mar 13, 2024
|
I would prefer as it was before, now it's too tight on Photos page, too close to scrollbar...
|
|
I would prefer the early look also because otherwise, it looks too compact ( negative space is very important ), and also the layout shift while hovering over dates causes issues with navigation ( For elderly people ). |
|
@arpanghosh8453 it has been fixed and will be available in the next release |
|
Hey there! It's Alex @alextran1502 (Our CEO) again saving my day! Thank you so much! You are so fast to reply dude! It's been 2 minutes since I made this comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeline / asset-grid has a
1remleft-margin that results in the sidebar looking larger than it actually is. Removing the margin makes the sidebar have even spacing and as bonus adds a little more room for photos. With this change photos are no longer offset from the main page titles likeArchiveandFavoritesbut those are stickied to the top anyway.Update: Also removed the left padding on the search bar so it's even with the timline. Pics below do not reflect this change.
Original:
Left margin removed:
