Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): queue library asset refresh in batches #7914

Merged
merged 9 commits into from Mar 14, 2024

Conversation

etnoy
Copy link
Contributor

@etnoy etnoy commented Mar 12, 2024

  • Added verbose logs to library refresh queuing
  • Perform queuing in batches

This fixes #7373 and allows large libraries of ~1M assets to be refreshed without running out of memory

Shinyness:
image

Copy link

cloudflare-pages bot commented Mar 12, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae1a37c
Status: ✅  Deploy successful!
Preview URL: https://e01e939f.immich.pages.dev
Branch Preview URL: https://chore-extra-logs-github-7373.immich.pages.dev

View logs

server/src/domain/library/library.service.ts Outdated Show resolved Hide resolved
server/src/domain/library/library.service.ts Outdated Show resolved Hide resolved
server/src/domain/library/library.service.ts Outdated Show resolved Hide resolved
server/src/domain/library/library.service.ts Outdated Show resolved Hide resolved
server/src/domain/library/library.service.ts Outdated Show resolved Hide resolved
server/src/domain/library/library.service.ts Outdated Show resolved Hide resolved
@etnoy etnoy changed the title chore: Testing stuff for issue 7373 fix(server): queue asset refresh in batches Mar 13, 2024
@etnoy etnoy changed the title fix(server): queue asset refresh in batches fix(server): queue library asset refresh in batches Mar 13, 2024
@etnoy etnoy marked this pull request as ready for review March 13, 2024 19:18
@etnoy etnoy merged commit ba38713 into main Mar 14, 2024
24 checks passed
@etnoy etnoy deleted the chore/extra-logs-github-7373 branch March 14, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Out of memory when scanning libraries with >1M assets
2 participants