perf(server): optimize getByIds query
#7918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
ae024fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1331f971.immich.pages.dev |
| Branch Preview URL: | https://perf-server-getbyids.immich.pages.dev |
remove index from person entity add to face entity fix
mertalev
force-pushed
the
perf/server-getbyids
branch
from
8cef805
to
33418de
Compare
jrasm91
approved these changes
Mar 13, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR splits
getByIdsinto two methods: one that doesn't include any relations by default and one that includes all of them. Of its current usages, all of the ones internal to the server have been checked to see which, if any, relations are required (most of them don't require any). The ones used for API responses use the variant with all relations since they're more work to figure out.Also, as suggested in #7909, this adds a few indices needed for queries involving the stack, tag and person relations to be performant. I tested and can confirm the massive performance difference described in that issue.
Fixes #7909