feat(web): preload assets in photo-viewer #7920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
preloadAssets = writable<AssetResponseDto[]>([]);
toasset-viewing.store
to allow one or more assets to be preloaded after the primary asset has been loaded.Design choices:
AssetTypeEnum.Image
, didn't want to interfere with video streamingThe actual loading is currently in
photo-viewer
because it has the information when the primary is finished loading as well as the helperdownloadRequest
. Although maybe it makes sense to add an event when primary loading is done and do pre-loading inasset-grid
orasset-viewer
?Tested by clearing cache, not enabling disable cache, and setting throttling to a slower connection. Tested both navigating around as well as slideshow.
Does not address the issue in Firefox and the XHR abort not happening.
before without preload
before.webm
after with preload
after with preload.webm