feat(mobile): Remote thumbnails and images use an on-disk image cache #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
format format Fix typo in equals remove unused import renames image loader
Deploying immich with
|
| Latest commit: |
96b7984
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://83f0a77e.immich.pages.dev |
| Branch Preview URL: | https://feat-on-disk-image-cache.immich.pages.dev |
fyfrey
reviewed
Mar 14, 2024
mobile/lib/modules/asset_viewer/image_providers/cache/image_loader.dart
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| throw Exception('No file found in cache'); |
There was a problem hiding this comment.
I hope we never reach this exception. If we do, it's a bit misleading. This exception can also occur if the download failed I believe.
There was a problem hiding this comment.
Yeah this is one of those "this code will never execute" scenarios
😂
I largely copied the code from the CachedNetworkImage folks because their implementation worked so dang well, but they use a Stream and I only need a Future, so I needed to return something... What do you think we should do here? I could try to rework this into something more legible...
There was a problem hiding this comment.
Maybe just "could not load image ID"
mobile/lib/modules/asset_viewer/image_providers/cache/thumbnail_image_cache_manager.dart
Outdated
Show resolved
Hide resolved
mobile/lib/modules/asset_viewer/image_providers/cache/remote_image_cache_manager.dart
Show resolved
Hide resolved
fyfrey
approved these changes
Mar 14, 2024
alextran1502
approved these changes
Mar 14, 2024
|
Amazing work! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImmichRemoteImageProviderusingthumbnail: truewithImmichRemoteThumbnailProviderImageCacheManager.getImageFilewhich uses an on device cache