Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add millisecond options to storage template settings #7942

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

sevtdy
Copy link
Contributor

@sevtdy sevtdy commented Mar 14, 2024

Proposing to add an option for SSS (milliseconds) to the storage template.

Currently, my storage template setting looks like this:
{{y}}/{{y}}-{{MM}}/{{y}}{{MM}}{{dd}}_{{HH}}{{mm}}{{ss}}
UPLOAD_LOCATION/admin/2022/2022-02/20220203_045605.jpg

Although immich append +1, +2, etc. when the filename is duplicated, I would prefer to avoid this.
I believe that adding an SSS (millisecond) option to the template would make more sense and be more suitable for most situations.

take my as example, ideally would be like this:
{{y}}/{{y}}-{{MM}}/{{y}}{{MM}}{{dd}}_{{HH}}{{mm}}{{ss}}_{{SSS}}
UPLOAD_LOCATION/admin/2022/2022-02/20220203_045605_055.jpg
UPLOAD_LOCATION/admin/2022/2022-02/20220203_045605_171.jpg

related: #6545

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Do you want to add a preset with it?

@sevtdy
Copy link
Contributor Author

sevtdy commented Mar 14, 2024

@jrasm91 thanks for the prompt review.

I think it's okay to keep the preset unchanged. Time format preferences can vary greatly among different users. We can manually setup this.

Additionally, I've added a new commit to fix the test case. Kindly review it again.

@sevtdy sevtdy changed the title feat(web): add millisecond options storage template settings feat(web): add millisecond options to storage template settings Mar 14, 2024
@sevtdy sevtdy requested a review from jrasm91 March 14, 2024 09:25
… of github.com:immich-app/immich into millisecond
@alextran1502 alextran1502 enabled auto-merge (squash) March 15, 2024 20:06
@alextran1502 alextran1502 merged commit 64f53e6 into immich-app:main Mar 15, 2024
23 checks passed
@sevtdy sevtdy deleted the millisecond branch May 9, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants