fix(server): prevent feedback loop during library scan

[mertalev]

Description

We don't handle the case where the library path contains the thumbs or encoded-videos folders, leading to a nasty feedback loop. This adds that check during the scan.

Fixes #7864

[cloudflare-pages]

Deploying immich with    Cloudflare Pages

Latest commit:	be4f864
Status:	✅  Deploy successful!
Preview URL:	https://64ce50ae.immich.pages.dev
Branch Preview URL:	https://fix-server-library-scan-recu.immich.pages.dev

View logs

[etnoy]

LGTM. It won't be foolproof due to docker mounts but it'll catch most issues

[bo0tzz]

Should we try to cover this case in validateImportPath so it is surfaced to the admin? I think it would also be worth adding a WARN log in the skip clause so it is clear what is happening.

[etnoy]

Should we try to cover this case in validateImportPath so it is surfaced to the admin? I think it would also be worth adding a WARN log in the skip clause so it is clear what is happening.

Great suggestion.

[jrasm91]

Honestly, nothing inside of the media dir should be picked up by external libraries imo.

[mertalev]

I was thinking of if someone has a folder in /usr/src/app/upload/external or something. Or should we just require that you mount it somewhere else?

[jrasm91]

I was thinking of if someone has a folder in /usr/src/app/upload/external or something. Or should we just require that you mount it somewhere else?

I think that would be fine. Storing an external folder inside of the immich-controlled "upload" folder just seems like a bad idea.