You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keyboard shortcuts are currently handled pretty inconsistently and maybe in an unexpected way. Let's look at an example listening for the escape key using on:keydown={(e) => e.key === 'Escape'}. This not only triggers when pressing escape, but also with any combination of modifier key (ctrl, alt, shift or meta). Another issue may arise when listening for a key that is entered in an input field, where the event handler will still execute.
In some cases these issues are accounted for, but not everywhere. A new action use:shortcut and function executeShortcuts are added that manage these pitfalls. However, they aren't yet used everywhere as it would make this PR a bit large.
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. Eventually would it be possible to automatically show a list of registered shortcuts when you press ?? Like make that modal, which is currently static, dynamic?
It can be done, but it's a little tricky. You need to register all shortcuts and add some logic for filtering out duplicate and irrelevant shortcuts such as enter or escape. Hoewever, this PR should make it a lot easier to implement that.
It can be done, but it's a little tricky. You need to register all shortcuts and add some logic for filtering out duplicate and irrelevant shortcuts such as enter or escape. Hoewever, this PR should make it a lot easier to implement that.
Yeah that makes sense. I assumed we'd have to add something like title: string and/or description: string to the ones that would be included. I also think you'd need to register them all directly, instead of using the deferred executeShortcuts implementation, which looks just like shorthand for shortcut aliases.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard shortcuts are currently handled pretty inconsistently and maybe in an unexpected way. Let's look at an example listening for the escape key using
on:keydown={(e) => e.key === 'Escape'}. This not only triggers when pressing escape, but also with any combination of modifier key (ctrl, alt, shift or meta). Another issue may arise when listening for a key that is entered in an input field, where the event handler will still execute.In some cases these issues are accounted for, but not everywhere. A new action
use:shortcutand functionexecuteShortcutsare added that manage these pitfalls. However, they aren't yet used everywhere as it would make this PR a bit large.