refactor: library e2e #7969
Merged
refactor: library e2e #7969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying immich with
|
| Latest commit: |
18a0a3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://913952af.immich.pages.dev |
| Branch Preview URL: | https://refactor-library-e2e.immich.pages.dev |
jrasm91
force-pushed
the
refactor/library-e2e
branch
from
9d7e23a
to
aa7c19e
Compare
danieldietzler
approved these changes
Mar 15, 2024
| if (callback) { | ||
| callback(); | ||
| delete callbacks[id]; | ||
| // console.log(`Received event: ${event} [id=${id}]`); |
There was a problem hiding this comment.
Yeah it is good for debugging, but it's quite noisy
danieldietzler
force-pushed
the
refactor/library-e2e
branch
from
aa7c19e
to
40c7b6f
Compare
danieldietzler
force-pushed
the
refactor/library-e2e
branch
from
40c7b6f
to
18a0a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With help from @danieldietzler, moving some of the library e2e tests over.