refactor: server events #8204
Merged
refactor: server events #8204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrasm91
commented
Mar 22, 2024
•
jrasm91
commented
- rename communication to event
- use event emitter instead of callbacks for config update (cross-process event)
- user event emitter instead of callbacks for websocket connection event (in-process event)
Deploying immich with
|
| Latest commit: |
dd169e9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19f56b0d.immich.pages.dev |
| Branch Preview URL: | https://refactor-server-events.immich.pages.dev |
jrasm91
commented
Mar 22, 2024
| export class CommunicationRepository | ||
| implements OnGatewayConnection, OnGatewayDisconnect, OnGatewayInit, ICommunicationRepository | ||
| { | ||
| private logger = new ImmichLogger(CommunicationRepository.name); |
There was a problem hiding this comment.
This is all basically gone - no more need to store, register, and invoke callbacks.
jrasm91
force-pushed
the
refactor/server-events
branch
from
0473683
to
601fd63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.