Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): albums list (2) #8214

Merged
merged 3 commits into from
Mar 24, 2024
Merged

refactor(web): albums list (2) #8214

merged 3 commits into from
Mar 24, 2024

Conversation

martabal
Copy link
Member

@martabal martabal commented Mar 23, 2024

Following #7966, This PR moves the shared / owned / all views to the same albums list

Screenshots

Full screen

Screenshot from 2024-03-23 10-08-29

Iphone screen

image

Copy link

cloudflare-pages bot commented Mar 23, 2024

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: 09970c1
Status: ✅  Deploy successful!
Preview URL: https://3ea1b241.immich.pages.dev
Branch Preview URL: https://refactor-albums-list-3.immich.pages.dev

View logs

@martabal martabal force-pushed the refactor/albums-list-3 branch 3 times, most recently from e1125e2 to 99fa8c4 Compare March 23, 2024 17:40
@martabal martabal marked this pull request as ready for review March 23, 2024 18:08
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. With the removal of albums from "sharing", the page doesn't do much anymore. There are a few things we still need though, but that page right now looks pretty empty. We still need a way to view all shared-links. We also need a way to get to partner photos. I like having all the albums under the album page, but I think we might want to change something about the sharing page although I don't know exactly what to do.

@alextran1502
Copy link
Contributor

Please keep the sharing page as is for now. We add these options to the Albums page for convenience

@alextran1502 alextran1502 merged commit 5dc59b5 into main Mar 24, 2024
24 checks passed
@alextran1502 alextran1502 deleted the refactor/albums-list-3 branch March 24, 2024 18:07
@waclaw66
Copy link
Contributor

One remark, there is preseleced no choice from All, Owned and Shared by default, therefore no albums will be shown after new release update.

@martabal
Copy link
Member Author

One remark, there is preseleced no choice from All, Owned and Shared by default, therefore no albums will be shown after new release update.

Yeah, you just need to click once on one of the new buttons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants