-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(web): albums list (2) #8214
Conversation
Deploying immich with
|
Latest commit: |
09970c1
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3ea1b241.immich.pages.dev |
Branch Preview URL: | https://refactor-albums-list-3.immich.pages.dev |
e1125e2
to
99fa8c4
Compare
99fa8c4
to
f031ac8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. With the removal of albums from "sharing", the page doesn't do much anymore. There are a few things we still need though, but that page right now looks pretty empty. We still need a way to view all shared-links. We also need a way to get to partner photos. I like having all the albums under the album page, but I think we might want to change something about the sharing page although I don't know exactly what to do.
Please keep the sharing page as is for now. We add these options to the Albums page for convenience |
One remark, there is preseleced no choice from All, Owned and Shared by default, therefore no albums will be shown after new release update. |
Yeah, you just need to click once on one of the new buttons |
Following #7966, This PR moves the shared / owned / all views to the same albums list
Screenshots
Full screen
Iphone screen