Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add immich cli to container #8239

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

danieldietzler
Copy link
Member

@danieldietzler danieldietzler commented Mar 24, 2024

In contrary to what was removed in #8224, this will always install the latest version from npm. By this, the cli will actually always be up to date (with the latest published version)

Copy link

cloudflare-pages bot commented Mar 24, 2024

Deploying immich with  Cloudflare Pages  Cloudflare Pages

Latest commit: c1e49d8
Status: ✅  Deploy successful!
Preview URL: https://4c0c81b2.immich.pages.dev
Branch Preview URL: https://feat-server-container-cli.immich.pages.dev

View logs

@martabal
Copy link
Member

Couldn't this be an issue if a new version of the CLI is released at the same time as the server?

@danieldietzler
Copy link
Member Author

Couldn't this be an issue if a new version of the CLI is released at the same time as the server?

The idea is to always publish the cli first, and then build the server afaik.

@jrasm91 jrasm91 merged commit 1694dd1 into main Mar 25, 2024
25 checks passed
@jrasm91 jrasm91 deleted the feat/server-container-cli branch March 25, 2024 12:18
@martabal
Copy link
Member

The idea is to always publish the cli first, and then build the server afaik.

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants