Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): removed deprecated version line in docker compose files #8276

Merged
merged 1 commit into from Mar 25, 2024

Conversation

JordyEGNL
Copy link
Contributor

This PR removes the version: '3.8' lines in all docker-compose files.

It also removes this warning message shown in the console.
image

Closes #8256

More information can be found here: https://github.com/compose-spec/compose-spec/blob/master/04-version-and-name.md
And here: mailcow/mailcow-dockerized#5797

@JordyEGNL
Copy link
Contributor Author

I am unsure if the version string can also be removed from hwaccel.ml.yml and hwaccel.transcoding.yml because I dont use those.

@alextran1502
Copy link
Contributor

if you use older version of docker and docker compose what would happen?

@danieldietzler
Copy link
Member

if you use older version of docker and docker compose what would happen?

AFAIK this should always be fine. Version 3.x is the default for a long time, so the name field is still the part that gives the version limit

@danieldietzler danieldietzler added the deployment Deployment related tasks label Mar 25, 2024
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JordyEGNL
Copy link
Contributor Author

if you use older version of docker and docker compose what would happen?

This is what the official documentation says
The top-level version property is defined by the Compose Specification for backward compatibility. It is only informative.

I have also tested this with docker version 5:20.10.24~3-0~ubuntu-jammy and it works fine

@jrasm91 jrasm91 merged commit 636f5fb into immich-app:main Mar 25, 2024
23 of 24 checks passed
HarrisonWang added a commit to HarrisonWang/awesome-compose that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Deployment related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker-compose.yml: version is obsolete
4 participants