-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web): show download button correctly based on shared link permission #8288
Conversation
Deploying immich with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can detect if it is a shared link without passing it down as a prop on all of those components.
@@ -192,6 +193,10 @@ | |||
} | |||
|
|||
onMount(async () => { | |||
if (isSharedLink()) { | |||
sharedLink = await getMySharedLink({ key: getKey() }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this load the shared link every time the component is opened? This might not be ideal. Another option would be to use the context api or a store for tracking state related to the shared link.
fix #8248